Changeset 3044

Timestamp:

11/15/05 11:35:14 (3 years ago)

Author:

bitsweat

Message:

SQLServer: active? and reconnect! methods for handling stale connections. References #428.

Files:

• trunk/activerecord/CHANGELOG (modified) (1 diff)
• trunk/activerecord/lib/active_record/connection_adapters/sqlserver_adapter.rb (modified) (3 diffs)

trunk/activerecord/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* SQLServer: active? and reconnect! methods for handling stale connections.  #428 [kajism@yahoo.com]
-
-* Associations handle case-equality more consistently: item.parts.is_a?(Array) and item.parts === Array.  #1345 [MarkusQ@reality.com]

trunk/activerecord/lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -31 +31 @@
-        raise ArgumentError, "Missing DSN. Argument ':dsn' must be set in order for this adapter to work." unless config.has_key?(:dsn)
-        dsn       = config[:dsn]
-conn      = DBI.connect("DBI:ODBC:#{dsn}", username, password)
+driver_url = "DBI:ODBC:#{dsn}"
-      else
-        raise ArgumentError, "Missing Database. Argument ':database' must be set in order for this adapter to work." unless config.has_key?(:database)
-        database  = config[:database]
-        host      = config[:host] ? config[:host].to_s : 'localhost'
-
-
+
+
+
-
-      conn["AutoCommit"] = true
-
+, [driver_url, username, password]
-    end
-  end # class Base
@@ -173 +174 @@
-    # [Linux strongmad 2.6.11-1.1369_FC4 #1 Thu Jun 2 22:55:56 EDT 2005 i686 i686 i386 GNU/Linux]
-    class SQLServerAdapter < AbstractAdapter
+    
+      def initialize(connection, logger, connection_options=nil)
+        super(connection, logger)
+        @connection_options = connection_options
+      end
+
-      def native_database_types
-        {
@@ -196 +203 @@
-        true
-      end
+
+      # CONNECTION MANAGEMENT ====================================#
+
+      # Returns true if the connection is active.
+      def active?
+        @connection.execute("SELECT 1") {|sth|}
+        true
+      rescue DBI::DatabaseError => e
+        false
+      end
+
+      # Reconnects to the database.
+      def reconnect!
+        begin
+          @connection.disconnect
+          @connection = DBI.connect(*@connection_options)
+        rescue DBI::DatabaseError => e
+          @logger.warn "#{adapter_name} automatic reconnection failed: #{e.message}"
+        end
+      end
+
+
-
-      def select_all(sql, name = nil)