Navigation

Changeset 5757

Timestamp:

12/19/06 23:16:10 (2 years ago)

Author:

bitsweat

Message:

Silence log_error deprecation warnings from inspecting deprecated instance variables.

Files:

r5755	r5757
1	1	SVN
	2
	3	* Silence log_error deprecation warnings from inspecting deprecated instance variables. [Nate Wiger]
2	4
3	5	* Only cache GET requests with a 200 OK response. #6514, #6743 [RSL, anamba]

r5706	r5757
60	60	# Overwrite to implement custom logging of errors. By default logs as fatal.
61	61	def log_error(exception) #:doc:
62		if ActionView::TemplateError === exception
63		logger.fatal(exception.to_s)
64		else
65		logger.fatal(
66		"\n\n#{exception.class} (#{exception.message}):\n " +
67		clean_backtrace(exception).join("\n ") +
68		"\n\n"
69		)
	62	ActiveSupport::Deprecation.silence do
	63	if ActionView::TemplateError === exception
	64	logger.fatal(exception.to_s)
	65	else
	66	logger.fatal(
	67	"\n\n#{exception.class} (#{exception.message}):\n " +
	68	clean_backtrace(exception).join("\n ") +
	69	"\n\n"
	70	)
	71	end
70	72	end
71	73	end

r5730	r5757
46	46	end
47	47
48		def test_assertion_failed_error_doesnt_spout_deprecation_warnings
	48	def test_log_error_silences_deprecation_warnings
	49	get :raises_name_error
	50	rescue => e
	51	assert_not_deprecated { @controller.send :log_error, e }
	52	end
	53
	54	def test_assertion_failed_error_silences_deprecation_warnings
49	55	get :raises_name_error
50	56	rescue => e