Changeset 6842

Timestamp:

05/25/07 21:21:41 (2 years ago)

Author:

bitsweat

Message:

Migrations: add_column supports custom column types. Closes #7742. First-patch cheers to jsgarvin\!

Files:

• trunk/activerecord/CHANGELOG (modified) (1 diff)
• trunk/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb (modified) (1 diff)
• trunk/activerecord/test/migration_test.rb (modified) (1 diff)

trunk/activerecord/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Migrations: add_column supports custom column types.  #7742 [jsgarvin, Theory]
-
-* Load database adapters on demand. Eliminates config.connection_adapters and RAILS_CONNECTION_ADAPTERS. Add your lib directory to the $LOAD_PATH and put your custom adapter in lib/active_record/connection_adapters/adaptername_adapter.rb. This way you can provide custom adapters as plugins or gems without modifying Rails. [Jeremy Kemper]

trunk/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb

@@ -254 +254 @@
-
-      def type_to_sql(type, limit = nil, precision = nil, scale = nil) #:nodoc:
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
-            else
-column_type_sql << "(#{precision})"
+raise ArgumentError, "Error adding decimal column: precision cannot be empty if scale if specified" if scale
-            end
+            column_type_sql
-          else
-
+
+
+
-          end
-          column_type_sql
-        else
-
-
-
+
-        end
-      end

trunk/activerecord/test/migration_test.rb

@@ -313 +313 @@
-      assert_equal TrueClass, bob.male?.class
-      assert_kind_of BigDecimal, bob.wealth
+    end
+
+    if current_adapter?(:MysqlAdapter)
+      def test_unabstracted_database_dependent_types
+        Person.delete_all
+
+        ActiveRecord::Migration.add_column :people, :intelligence_quotient, :tinyint
+        Person.create :intelligence_quotient => 300
+        jonnyg = Person.find(:first) 
+        assert_equal 127, jonnyg.intelligence_quotient
+        jonnyg.destroy
+      ensure
+        ActiveRecord::Migration.remove_column :people, :intelligece_quotient rescue nil
+      end
-    end
-