Changeset 7942

Timestamp:

10/16/07 07:24:23 (1 year ago)

Author:

bitsweat

Message:

Fix regression where the association would not construct new finder SQL on save causing bogus queries for "WHERE owner_id = NULL" even after owner was saved. Closes #8713.

Files:

• trunk/activerecord/CHANGELOG (modified) (1 diff)
• trunk/activerecord/lib/active_record/associations.rb (modified) (1 diff)
• trunk/activerecord/test/associations_test.rb (modified) (2 diffs)

trunk/activerecord/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Fix regression where the association would not construct new finder SQL on save causing bogus queries for "WHERE owner_id = NULL" even after owner was saved.  #8713 [Bryan Helmkamp]
-
-* Refactor association create and build so before & after callbacks behave consistently.  #8854 [lifofifo, mortent]

trunk/activerecord/lib/active_record/associations.rb

@@ -1084 +1084 @@
-            end
-
-if !
-  records_to_save.each { |record| association.send(:insert_record, record) }
-  association.send(:construct_sql)   
-end
+records_to_save.each { |record| association.send(:insert_record, record) } unless 
+
+
+association.send(:construct_sql) if association.respond_to?(:construct_sql)
-          end_eval
-

trunk/activerecord/test/associations_test.rb

@@ -15 +15 @@
-require 'fixtures/tag'
-require 'fixtures/tagging'
+require 'fixtures/person'
+require 'fixtures/reader'
-
-class AssociationsTest < Test::Unit::TestCase
@@ -24 +26 @@
-      Class.new(ActiveRecord::Base).has_many(:wheels, :name => 'wheels')
-    end
+  end
+  
+  def test_should_construct_new_finder_sql_after_create
+    person = Person.new
+    assert_equal [], person.readers.find(:all)
+    person.save!
+    reader = Reader.create! :person => person, :post => Post.new(:title => "foo", :body => "bar")
+    assert_equal [reader], person.readers.find(:all)
-  end
-