Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #11254 (closed defect: fixed)

Opened 9 months ago

Last modified 9 months ago

[PATCH][TINY][DOCS] Fixing typos in docs from ActiveSupport::Callbacks

Reported by: ernesto.jimenez Assigned to: core
Priority: normal Milestone: 2.x
Component: ActiveRecord Version: edge
Severity: normal Keywords: verified
Cc:

Attachments

doc_for_active_support_callbacks.diff (3.3 kB) - added by ernesto.jimenez on 02/29/08 18:28:44.
typos_fixed.diff (1.2 kB) - added by ernesto.jimenez on 03/06/08 14:31:42.
Patch fixing typos against r8985

Change History

02/29/08 18:28:44 changed by ernesto.jimenez

  • attachment doc_for_active_support_callbacks.diff added.

02/29/08 18:31:34 changed by ernesto.jimenez

  • summary changed from [DOC] Doc for ActiveSupport::Callbacks to [PATCH][DOCS] Docs for ActiveSupport::Callbacks.

02/29/08 18:35:38 changed by david.calavera

+1

02/29/08 18:37:13 changed by raul

+1

02/29/08 18:40:41 changed by jcarb

+1

02/29/08 18:44:52 changed by ernesto.jimenez

  • keywords set to verified.

02/29/08 18:45:15 changed by jramirez

+1

03/05/08 10:53:38 changed by pratik

  • status changed from new to closed.
  • resolution set to fixed.

(In [8984]) Docs for ActiveSupport::Callbacks. Closes #11254 [ernesto.jimenez]

03/06/08 11:37:51 changed by Henrik N

  • status changed from closed to reopened.
  • resolution deleted.

No time to submit a patch right now, but noticed some typos/similar:

"This mixing this module allos you to define callbacks in your class." --> "Mixing in this module allows you …"

"If a block is given it will be called after each callback reciving as arguments:" --> "receiving as arguments". I'd drop the ":" as well.

"If the result from the block evaluates as false, callback chain is stopped." --> "evaluates to", "the callback chain"

Reopening, hope that's fine.

03/06/08 14:31:42 changed by ernesto.jimenez

  • attachment typos_fixed.diff added.

Patch fixing typos against r8985

03/06/08 14:32:41 changed by ernesto.jimenez

  • summary changed from [PATCH][DOCS] Docs for ActiveSupport::Callbacks to [PATCH][TINY][DOCS] Fixing typos in docs from ActiveSupport::Callbacks.

Thank you Henrik.

I have submited a tiny patch fixing the typos

03/07/08 11:17:41 changed by pratik

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [8988]) Fixed typos in ActiveSupport::Callbacks documentation. Closes #11254