[PATCH] Added Inflections camelizes and acronym methods to allow for configuring reversible camelize and underscore

Hopefully this is better formatted for the usage example:

 Inflector.inflections do |inflect|
     inflect.plural /^(ox)$/i, '\1en'
     inflect.acronym 'PDF'
     inflect.acronym 'html'
 end

+1

This would be useful in stuff we do with namespaces. We've run into problems with the way that the paths are determined that would be fixed by this patch.

added implementation and test cases for camel with module with this patch.

Excellent idea. I've been bitten by UUID, HTML and other acronym camelizing since Day One.

Good idea, but I would change

def acronym(acronym) 
  acronym.downcase! 
  rule = Regexp.new("(^|_)#{acronym}") 
  camelize(rule, acronym.upcase!) 
end

to

def acronym(acronym) 
  acronym = acronym.downcase 
  rule = Regexp.new("(^|_)#{Regexp.escape(acronym)}") 
  camelize(rule, acronym.upcase) 
end

Regexp.escape so that something like

inflect.acronym "W.T.F."

isn't treated as a regexp. Perhaps it will never be used with anything but alphanumerics, but it seems like a good idea to be careful.

And not using upcase!/downcase! so we don't alter the passed-in string outside the method.

Replying to Henrik N:

acronym = acronym.downcase rule = Regexp.new("(^{|_)#{Regexp.escape(acronym)}")}

Or just

rule = Regexp.new("(^|_)#{Regexp.escape(acronym.downcase)}")

Thanks Henrik for the advice. I'll create a new patch soon with your recommendations.