Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #11596 (new enhancement)

Opened 8 months ago

Last modified 8 months ago

[PATCH] Railties databases.rake: match adapter names more leniently

Reported by: nicksieger Assigned to: core
Priority: normal Milestone: 2.x
Component: Railties Version: edge
Severity: normal Keywords:
Cc: nicksieger

Description

In JRuby we've started the convention of 'jdbcmysql', 'jdbcpostgresql' etc. as adapter names for the JDBC-equivalents of those databases, but the out-of-the-box database tasks won't work with those because they match on the exact adapter name.

These patches (one for edge, one for 2-0-stable) change the when clauses to regexes to allow them to work with JRuby/JDBC, and also open the door to other alternate implementations of database adapters.

Anyone see any issues with relaxing these?

Attachments

edge-0001-Change-all-databases.rake-adapter-when-statements.patch (7.5 kB) - added by nicksieger on 04/15/08 13:48:52.
2-0-stable-0001-Change-all-databases.rake-adapter-when-statements.patch (7.7 kB) - added by nicksieger on 04/15/08 13:49:21.

Change History

04/15/08 13:48:52 changed by nicksieger

  • attachment edge-0001-Change-all-databases.rake-adapter-when-statements.patch added.

04/15/08 13:49:21 changed by nicksieger

  • attachment 2-0-stable-0001-Change-all-databases.rake-adapter-when-statements.patch added.

04/15/08 13:52:49 changed by nicksieger

Also in my github fork at:

master: http://github.com/nicksieger/rails/commit/202ec84c270ea69b66e01f2b618297ae2d179035

2-0-stable: http://github.com/nicksieger/rails/commit/d61c1ebb28d4292b87e85ccdba229a7a3c9a157c

04/16/08 21:38:15 changed by ManfredU

Change looks fine for me.

Manfred