collection object gets its own size and empty status wrong

See relevant code excerpts at:

http://www.rafb.net/paste/results/FLQv0b83.html

This occurs when a has_many relation uses finder_sql. The association's #size method uses counter_sql which is generated from finder_sql with a case-sensitive gsub, only accepting "SELECT ... FROM ...", so "select ... from ..." and any other variations will fail. Some kind of sanity check on the passed finder_sql would probably be useful, if not just to catch typos and such.

Here is the simple fix:

--- orig_has_many_association.rb        Mon Oct 25 19:42:40 2004
+++ has_many_association.rb     Mon Oct 25 15:58:49 2004
@@ -6,7 +6,7 @@
         @conditions = options[:conditions]
         
         if options[:finder_sql]
-          @counter_sql = options[:finder_sql].gsub(/SELECT (.*) FROM/, "SELECT COUNT(*) FROM")
+          @counter_sql = options[:finder_sql].gsub(/SELECT (.*) FROM/i, "SELECT COUNT(*) FROM")
           @finder_sql = options[:finder_sql]
         else
           @counter_sql = "#{@association_class_primary_key_name} = '#{@owner.id}'#{@conditions ? " AND " + @conditions : ""}"

Patched and resolved in Ticket #143.