[PATCH] add sequence_name support for postgresql

merged with previous fixture patch

Added a new version of the patch that is merged with the changes from #2224. This may also be a solution for #2016...

Updated for rev 2339. as a bonus, includes a call to reset_sequences in the belongs_to test since orders has no fixture.

Hello,

In this section of the patch, the documentation is incorrect for PostgreSQL.

       # Setting the sequence name when using other dbs will have no effect.
-      # If a sequence name is not explicitly set when using Oracle, it will
-      # default to the commonly used pattern of: #{table_name}_seq
+      # If a sequence name is not explicitly set, it will default to the 
+      # commonly used pattern of: #{table_name}_seq for Oracle and #{table_name}_id_seq
+      # for PostgreSQL.

It should probably read

+      # commonly used pattern of: #{table_name}_seq for Oracle and
+      # #{table_name}_#{pk}_seq for PostgreSQL.

Regards, Blair

Rick, Robby -- could you guys merge #2016 and #962 with this patch (or vice versa)?

merged w/ #962 and #2016

Merged. Also, moved reset_sequences and pgsql-specific code to the adapter so that create_fixtures will call that on any adapter with that method defined.

Okay, new version that incorporates the usage of COALESCE() in [2357]. I think the values were backwards, so it should be SELECT COALESCE(MAX(id)+1, 1) instead. I was getting mad breakage otherwise.

Also added a couple tests to adapter_test.rb to make sure tables with empty tables or tables with special pkeys are handled just like all the other tables.

get some coalesce() action up in here

I just wanted to add that if you're trying the new fixtures file and it's not working in your tests, try this in test_helper.rb:

require File.expand_path(File.dirname(__FILE__) + "/../config/environment")
require 'application'

require 'test/unit'
if File.directory?("#{RAILS_ROOT}/vendor/rails")
  require 'rails/activerecord/lib/active_record/fixtures'
  require 'rails/actionpack/lib/action_controller/test_process'
  require 'rails/actionwebservice/lib/action_web_service/test_invoke'
else
  require 'active_record/fixtures'
  require 'action_controller/test_process'
  require 'action_web_service/test_invoke'
end
require 'breakpoint'

It was loading everything from the latest gem (even though I had the vendor/rails directory) and driving me crazy.

Sequence support merged; fixtures changes pending #1911. Changesets [2639], [2640], [2641].

ghgh